fix: resolve all P0/P1 code quality issues
Some checks failed
CI / test (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
Security Scan / backend-security (push) Has been cancelled
Security Scan / frontend-security (push) Has been cancelled

P0 fixes:
- P0-01: sticky_session_test.go add context import
- P0-02: wire_gen.go add usageLogRepository parameter
- P0-03: admin_service_stub_test.go add GetGroupAPIKeyCount
- P0-04: admin_basic_handlers_test.go add stubUsageLogRepository

P1 fixes:
- P1-03: group_handler.go GetStats implement real data query

E2E fixes:
- Fix API Key path to /api/v1/keys (user endpoint)

Documentation:
- Update MEMORY.md with latest fixes
This commit is contained in:
Developer
2026-04-03 12:54:16 +08:00
parent 4bf838105b
commit 4d71566c0d
9 changed files with 224 additions and 34 deletions

View File

@@ -6,6 +6,7 @@ import (
"fmt"
"strconv"
"strings"
"time"
"github.com/Wei-Shaw/sub2api/internal/handler/dto"
"github.com/Wei-Shaw/sub2api/internal/pkg/response"
@@ -20,6 +21,7 @@ type GroupHandler struct {
adminService service.AdminService
dashboardService *service.DashboardService
groupCapacityService *service.GroupCapacityService
usageLogRepo service.UsageLogRepository
}
type optionalLimitField struct {
@@ -72,11 +74,12 @@ func (f optionalLimitField) ToServiceInput() *float64 {
}
// NewGroupHandler creates a new admin group handler
func NewGroupHandler(adminService service.AdminService, dashboardService *service.DashboardService, groupCapacityService *service.GroupCapacityService) *GroupHandler {
func NewGroupHandler(adminService service.AdminService, dashboardService *service.DashboardService, groupCapacityService *service.GroupCapacityService, usageLogRepo service.UsageLogRepository) *GroupHandler {
return &GroupHandler{
adminService: adminService,
dashboardService: dashboardService,
groupCapacityService: groupCapacityService,
usageLogRepo: usageLogRepo,
}
}
@@ -358,14 +361,48 @@ func (h *GroupHandler) GetStats(c *gin.Context) {
return
}
// Return mock data for now
ctx := c.Request.Context()
// Get group info
group, err := h.adminService.GetGroup(ctx, groupID)
if err != nil {
response.ErrorFrom(c, err)
return
}
// Get API key count
totalAPIKeys, err := h.adminService.GetGroupAPIKeyCount(ctx, groupID)
if err != nil {
response.ErrorFrom(c, err)
return
}
// Get today's usage stats
now := time.Now()
startOfDay := time.Date(now.Year(), now.Month(), now.Day(), 0, 0, 0, 0, now.Location())
stats, err := h.usageLogRepo.GetGroupStatsWithFilters(ctx, startOfDay, now, 0, 0, 0, groupID, nil, nil, nil)
if err != nil {
response.ErrorFrom(c, err)
return
}
// Calculate totals from stats
var totalRequests int64
var totalCost float64
for _, s := range stats {
totalRequests += s.Requests
totalCost += s.ActualCost
}
response.Success(c, gin.H{
"total_api_keys": 0,
"active_api_keys": 0,
"total_requests": 0,
"total_cost": 0.0,
"id": group.ID,
"name": group.Name,
"total_api_keys": totalAPIKeys,
"active_api_keys": totalAPIKeys, // All keys in group are considered active
"total_requests": totalRequests,
"total_cost": totalCost,
})
_ = groupID // TODO: implement actual stats
}
// GetUsageSummary returns today's and cumulative cost for all groups.