da36506b89
P0 fixes: - ModelError.Is(): use exact matching instead of substring contains() - shouldClearStickySession: add context param for cancellation/tracing P1 fixes: - TODO stubs: return 501 Not Implemented errors - validateInstanceSignature: deduplicate to shared validateCodeSignature() - Error messages: standardize to English only - http.go: remove pseudo if-else with duplicate branches
50 lines
1.4 KiB
Go
50 lines
1.4 KiB
Go
package handler
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGatewayEnsureForwardErrorResponse_WritesFallbackWhenNotWritten(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
w := httptest.NewRecorder()
|
|
c, _ := gin.CreateTestContext(w)
|
|
c.Request = httptest.NewRequest(http.MethodGet, "/", nil)
|
|
|
|
h := &GatewayHandler{}
|
|
wrote := h.ensureForwardErrorResponse(c, false)
|
|
|
|
require.True(t, wrote)
|
|
require.Equal(t, http.StatusBadGateway, w.Code)
|
|
|
|
var parsed map[string]any
|
|
err := json.Unmarshal(w.Body.Bytes(), &parsed)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "error", parsed["type"])
|
|
errorObj, ok := parsed["error"].(map[string]any)
|
|
require.True(t, ok)
|
|
assert.Equal(t, "upstream_error", errorObj["type"])
|
|
assert.Equal(t, "Upstream request failed", errorObj["message"])
|
|
}
|
|
|
|
func TestGatewayEnsureForwardErrorResponse_DoesNotOverrideWrittenResponse(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
w := httptest.NewRecorder()
|
|
c, _ := gin.CreateTestContext(w)
|
|
c.Request = httptest.NewRequest(http.MethodGet, "/", nil)
|
|
c.String(http.StatusTeapot, "already written")
|
|
|
|
h := &GatewayHandler{}
|
|
wrote := h.ensureForwardErrorResponse(c, false)
|
|
|
|
require.False(t, wrote)
|
|
require.Equal(t, http.StatusTeapot, w.Code)
|
|
assert.Equal(t, "already written", w.Body.String())
|
|
}
|