1. config.go: AI_CS_ENV runtime mode with production restriction - New RuntimeConfig.Env field (AI_CS_ENV / AI_CS_RUNTIME_ENV) - production + Postgres.Enabled=false → Load() returns error - production + empty webhook secret → Load() returns error - normalizeRuntimeEnv: dev/dev/ → development, prod/production → production, test → test 2. app.go: probe.SetReady only when store is confirmed ready - Postgres.Enabled: probe.SetReady(true) after DB+migration OK - Memory mode: probe.SetReady(false) — not production-ready 3. health_handler_test.go: add probe live+ready state transition tests 4. config_test.go: add TestLoad_RejectsProdWhenPostgresDisabled, TestLoad_RejectsProdWhenWebhookSecretMissing 5. app_test.go: add TestNew_RejectsMemoryModeWithoutExplicitNonProdEnv, TestNew_AllowsMemoryModeInTestEnv, TestNew_WithPostgresEnabled_* for invalid DSN and migration-failure paths Phase 1 (code gate) objectives met: ✅ prod cannot fall back to memory store ✅ readiness reflects actual store readiness ✅ both changes have test coverage
158 lines
4.3 KiB
Go
158 lines
4.3 KiB
Go
package config
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
)
|
|
|
|
type Config struct {
|
|
HTTP HTTPConfig
|
|
Postgres PostgresConfig
|
|
Webhook WebhookConfig
|
|
Runtime RuntimeConfig
|
|
}
|
|
|
|
type RuntimeConfig struct {
|
|
Env string
|
|
}
|
|
|
|
type HTTPConfig struct {
|
|
Addr string
|
|
ReadHeaderTimeout int
|
|
ReadTimeout int
|
|
WriteTimeout int
|
|
IdleTimeout int
|
|
MaxHeaderBytes int
|
|
MaxBodyBytes int64
|
|
}
|
|
|
|
type PostgresConfig struct {
|
|
Enabled bool
|
|
DSN string
|
|
MigrationDir string
|
|
MaxOpenConns int
|
|
MaxIdleConns int
|
|
ConnMaxLifetime int
|
|
}
|
|
|
|
type WebhookConfig struct {
|
|
Secret string
|
|
TimestampHeader string
|
|
SignatureHeader string
|
|
MaxSkewSeconds int
|
|
}
|
|
|
|
func Load() (*Config, error) {
|
|
cfg := &Config{
|
|
HTTP: HTTPConfig{
|
|
Addr: getEnv("AI_CS_ADDR", ":8080"),
|
|
ReadHeaderTimeout: getEnvInt("AI_CS_READ_HEADER_TIMEOUT_SEC", 5),
|
|
ReadTimeout: getEnvInt("AI_CS_READ_TIMEOUT_SEC", 10),
|
|
WriteTimeout: getEnvInt("AI_CS_WRITE_TIMEOUT_SEC", 15),
|
|
IdleTimeout: getEnvInt("AI_CS_IDLE_TIMEOUT_SEC", 60),
|
|
MaxHeaderBytes: getEnvInt("AI_CS_MAX_HEADER_BYTES", 1<<20),
|
|
MaxBodyBytes: getEnvInt64("AI_CS_MAX_BODY_BYTES", 1<<20),
|
|
},
|
|
Postgres: PostgresConfig{
|
|
Enabled: getEnvBool("AI_CS_POSTGRES_ENABLED", false),
|
|
DSN: getEnv("AI_CS_POSTGRES_DSN", ""),
|
|
MigrationDir: getEnv("AI_CS_POSTGRES_MIGRATION_DIR", "db/migration"),
|
|
MaxOpenConns: getEnvInt("AI_CS_POSTGRES_MAX_OPEN_CONNS", 20),
|
|
MaxIdleConns: getEnvInt("AI_CS_POSTGRES_MAX_IDLE_CONNS", 5),
|
|
ConnMaxLifetime: getEnvInt("AI_CS_POSTGRES_CONN_MAX_LIFETIME_SEC", 300),
|
|
},
|
|
Webhook: WebhookConfig{
|
|
Secret: getEnv("AI_CS_WEBHOOK_SECRET", ""),
|
|
TimestampHeader: getEnv("AI_CS_WEBHOOK_TIMESTAMP_HEADER", "X-CS-Timestamp"),
|
|
SignatureHeader: getEnv("AI_CS_WEBHOOK_SIGNATURE_HEADER", "X-CS-Signature"),
|
|
MaxSkewSeconds: getEnvInt("AI_CS_WEBHOOK_MAX_SKEW_SECONDS", 300),
|
|
},
|
|
Runtime: RuntimeConfig{
|
|
Env: normalizeRuntimeEnv(getEnv("AI_CS_RUNTIME_ENV", getEnv("AI_CS_ENV", "development"))),
|
|
},
|
|
}
|
|
if strings.TrimSpace(cfg.HTTP.Addr) == "" {
|
|
return nil, fmt.Errorf("AI_CS_ADDR must not be empty")
|
|
}
|
|
if cfg.HTTP.MaxBodyBytes <= 0 {
|
|
return nil, fmt.Errorf("AI_CS_MAX_BODY_BYTES must be positive")
|
|
}
|
|
if cfg.Postgres.Enabled && strings.TrimSpace(cfg.Postgres.DSN) == "" {
|
|
return nil, fmt.Errorf("AI_CS_POSTGRES_DSN must not be empty when postgres is enabled")
|
|
}
|
|
if cfg.Webhook.MaxSkewSeconds <= 0 {
|
|
return nil, fmt.Errorf("AI_CS_WEBHOOK_MAX_SKEW_SECONDS must be positive")
|
|
}
|
|
if cfg.Runtime.Env != "production" && cfg.Runtime.Env != "development" && cfg.Runtime.Env != "test" {
|
|
return nil, fmt.Errorf("AI_CS_RUNTIME_ENV must be one of production/development/test, got: %s", cfg.Runtime.Env)
|
|
}
|
|
if cfg.Runtime.Env == "production" && !cfg.Postgres.Enabled {
|
|
return nil, fmt.Errorf("AI_CS_RUNTIME_ENV=production requires AI_CS_POSTGRES_ENABLED=true, but it is false (memory fallback is not allowed in production)")
|
|
}
|
|
if cfg.Runtime.Env == "production" && strings.TrimSpace(cfg.Webhook.Secret) == "" {
|
|
return nil, fmt.Errorf("AI_CS_WEBHOOK_SECRET must not be empty in production")
|
|
}
|
|
return cfg, nil
|
|
}
|
|
|
|
func normalizeRuntimeEnv(value string) string {
|
|
switch strings.TrimSpace(strings.ToLower(value)) {
|
|
case "", "dev", "development":
|
|
return "development"
|
|
case "prod", "production":
|
|
return "production"
|
|
case "test":
|
|
return "test"
|
|
default:
|
|
return strings.TrimSpace(strings.ToLower(value))
|
|
}
|
|
}
|
|
|
|
func getEnv(key, fallback string) string {
|
|
if value := strings.TrimSpace(os.Getenv(key)); value != "" {
|
|
return value
|
|
}
|
|
return fallback
|
|
}
|
|
|
|
func getEnvInt(key string, fallback int) int {
|
|
value := strings.TrimSpace(os.Getenv(key))
|
|
if value == "" {
|
|
return fallback
|
|
}
|
|
parsed, err := strconv.Atoi(value)
|
|
if err != nil {
|
|
return fallback
|
|
}
|
|
return parsed
|
|
}
|
|
|
|
func getEnvInt64(key string, fallback int64) int64 {
|
|
value := strings.TrimSpace(os.Getenv(key))
|
|
if value == "" {
|
|
return fallback
|
|
}
|
|
parsed, err := strconv.ParseInt(value, 10, 64)
|
|
if err != nil {
|
|
return fallback
|
|
}
|
|
return parsed
|
|
}
|
|
|
|
func getEnvBool(key string, fallback bool) bool {
|
|
value := strings.TrimSpace(strings.ToLower(os.Getenv(key)))
|
|
if value == "" {
|
|
return fallback
|
|
}
|
|
switch value {
|
|
case "1", "true", "yes", "on":
|
|
return true
|
|
case "0", "false", "no", "off":
|
|
return false
|
|
default:
|
|
return fallback
|
|
}
|
|
}
|